Skip to content

Clone parity: add http and ssh network source coverage#29

Merged
Ismail-elkorchi merged 1 commit into
mainfrom
clone-network-http-ssh-parity
Feb 17, 2026
Merged

Clone parity: add http and ssh network source coverage#29
Ismail-elkorchi merged 1 commit into
mainfrom
clone-network-http-ssh-parity

Conversation

@Ismail-elkorchi

Copy link
Copy Markdown
Owner

Acceptance Criteria

  • Repo.clone accepts http and https and ssh sources while preserving branch and depth and filter and recurse-submodules option behavior.
  • Clone parity evidence for INV-FEAT-0053 includes local and file and http and https and ssh source coverage.
  • Gate scripts fail when clone parity evidence drops required network source checks.

Checklist

  • Added clone source resolution and transport probes for http and https and ssh sources.
  • Kept clone branch and depth and filter and recurse-submodules behavior aligned with baseline checks.
  • Added node parity tests for http and ssh clone flows with baseline comparisons.
  • Updated invariant and parity matrix wording for network clone scope.
  • Updated scripts/check and scripts/parity_matrix_check tokens for widened parity gates.
  • Ran node scripts/check --runtime=node successfully.

Simulated Role Reviews

Product review

Findings:

  • Clone parity scope excluded network source schemes from the clone API surface.
    Changes made:
  • Added http and https and ssh clone source handling with branch and depth and filter and recurse-submodules option support.
    Evidence pointers:
  • src/index.ts
  • docs/api.md

QA review

Findings:

  • INV-FEAT-0053 evidence lacked explicit tests for network clone sources.
    Changes made:
  • Added http and ssh clone parity tests with baseline comparisons for branch and depth and filter and recurse-submodules behavior.
    Evidence pointers:
  • tests/node/clone-receive-pack.test.mjs
  • node scripts/check --runtime=node

Security review

Findings:

  • Network clone flow required explicit credential handling and redacted progress behavior for ssh probes.
    Changes made:
  • Added ssh clone probe credential requirement and redacted progress message validation.
    Evidence pointers:
  • src/index.ts
  • tests/node/clone-receive-pack.test.mjs

Performance review

Findings:

  • Parity-gate drift risk increased as clone scope widened to network sources.
    Changes made:
  • Expanded clone gate checks in scripts/check and scripts/parity_matrix_check for network source tokens.
    Evidence pointers:
  • scripts/check
  • scripts/parity_matrix_check

Maintainer review

Findings:

  • Contract and invariant wording needed to match widened implementation scope.
    Changes made:
  • Updated docs/parity-matrix.md and spec/invariants.yaml and docs/api.md to cover local and file and http and https and ssh sources.
    Evidence pointers:
  • docs/parity-matrix.md
  • spec/invariants.yaml
  • docs/api.md

Expand clone parity coverage to http and https and ssh sources while preserving branch depth filter and recurse-submodules semantics and receive-pack parity gates.
@Ismail-elkorchi Ismail-elkorchi merged commit a284ba9 into main Feb 17, 2026
7 checks passed
@Ismail-elkorchi Ismail-elkorchi deleted the clone-network-http-ssh-parity branch February 17, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant